netdev - Re: [PATCH 2/3] netdev: Remove redundant checks for CAP_NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090903.201020.234843615.davem@davemloft.net>
Date:	Thu, 03 Sep 2009 20:10:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH 2/3] netdev: Remove redundant checks for CAP_NET_ADMIN
 in MDIO implementations

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Thu, 03 Sep 2009 21:39:43 +0100

> dev_ioctl() already checks capable(CAP_NET_ADMIN) before calling the
> driver's implementation of MDIO ioctls.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>

Man, it wasn't fun validating the cases where you removed the
check function-wide for a ->ndo_dev_ioctl() implementation. :-/

Applied...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html