netdev - Re: [PATCH net-next-2.6] vlan: adds drops accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090903.201131.194103894.davem@davemloft.net>
Date:	Thu, 03 Sep 2009 20:11:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] vlan: adds drops accounting

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 03 Sep 2009 12:39:16 +0200

> Its hard to tell if vlans are dropping frames, since
> every frame given to vlan_???_start_xmit() functions
> is accounted as fully transmitted by lower device.
> 
> We can test dev_queue_xmit() return values to
> properly account for dropped frames.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied.

But, how inappropriate would it be to keep doing the accounting
but pass the status back to the caller?  Or will that screw up
the qdisc running engine?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html