netdev - Re: [PATCH] ipv6: Fix tcp_v6_send_response(): it didn't set skb transport header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090903.204510.170648802.davem@davemloft.net>
Date:	Thu, 03 Sep 2009 20:45:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	cratiu@...acom.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: Fix tcp_v6_send_response(): it didn't set skb
 transport header

From: Cosmin Ratiu <cratiu@...acom.com>
Date: Thu, 3 Sep 2009 19:25:53 +0300

> Hello,
> 
> Here is a patch which fixes an issue observed when using TCP over IPv6 and AH 
> from IPsec.
> 
> When a connection gets closed the 4-way method and the last ACK from the 
> server gets dropped, the subsequent FINs from the client do not get ACKed 
> because tcp_v6_send_response does not set the transport header pointer. This 
> causes ah6_output to try to allocate a lot of memory, which typically fails, 
> so the ACKs never make it out of the stack.
> 
> I have reproduced the problem on kernel 2.6.7, but after looking at the latest 
> kernel it seems the problem is still there.
> 
> Signed-off-by: Cosmin Ratiu <cratiu@...acom.com>

Great catch.  IPV4 handles this transparently via ip_append_data()
which is what it uses to send these kinds of frames.  IPV6 does
this stuff by hand.

Applied to net-next-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html