netdev - Re: [net-next PATCH 1/3] ixgbe: Add support for multiple Tx queues for FCoE in 82599

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.WNT.4.64.0909032052420.800@ppwaskie-MOBL2.amr.corp.intel.com>
Date:	Thu, 3 Sep 2009 21:06:02 -0700 (Pacific Daylight Time)
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	David Miller <davem@...emloft.net>
cc:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>, "Zou, Yi" <yi.zou@...el.com>
Subject: Re: [net-next PATCH 1/3] ixgbe: Add support for multiple Tx queues
 for FCoE in 82599

On Thu, 3 Sep 2009, David Miller wrote:

> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Thu, 03 Sep 2009 17:55:50 -0700
> 
> > From: Yi Zou <yi.zou@...el.com>
> > 
> > This patch adds support for multiple transmit queues to the Fiber Channel
> > over Ethernet (FCoE) feature found in 82599. Currently, FCoE has multiple
> > Rx queues available, along with a redirection table, that helps distribute
> > the I/O load across multiple CPUs based on the FC exchange ID. To make
> > this the most effective, we need to provide the same layout of transmit
> > queues to match receive.
> > 
> > Particularly, when Data Center Bridging (DCB) is enabled, the designated
> > traffic class for FCoE can have dedicated queues for just FCoE traffic,
> > while not affecting any other type of traffic flow.
> > 
> > Signed-off-by: Yi Zou <yi.zou@...el.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> 
> Applied.
> 
> So does this eat into the TX queues available to non-FCOE traffic
> or is this a shared setup?

When DCB is enabled, then this is purely isolated to the FCoE traffic 
class.  When DCB is enabled, all the queues in the hardware are 
hard-partitioned.  Since our FCoE implementation sets a different MTU, and 
also disables packet split, to the FCoE queues, these are completely 
isolated.

Now when DCB is not enabled, 82599 operates in a kind of HBA-ish mode.  
FCoE and LAN will be running on the same queues, so yes, these queues 
would be eaten up from the LAN queues.

That all being said, 82599 has 128 Tx queues available.  But we only 
enable 1 queue per online CPU in today's driver without FCoE, so we won't 
run out of queues (yet).

Cheers,
-PJ
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html