netdev - Re: [PATCH] netlink: silence compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090904.203318.112406812.davem@davemloft.net>
Date:	Fri, 04 Sep 2009 20:33:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	brian.haley@...com
Cc:	marcel@...tmann.org, netdev@...r.kernel.org
Subject: Re: [PATCH] netlink: silence compiler warning

From: Brian Haley <brian.haley@...com>
Date: Fri, 04 Sep 2009 21:36:06 -0400

> Hi Marcel,
> 
> Marcel Holtmann wrote:
>> can we please add the err = -E... where it actually is needed and not
>> stupidly go ahead and silence compiler warnings with err = 0. This has
>> been posted before.
> 
> Sorry, I don't remember it being posted before.  If you look at the code
> though, err is correctly initialized, gcc just can't figure it out.  The
> choices I see are either what I originally posted, using uninitialized_var(err),
> or the patch below.  It doesn't matter to me.

uninitialized_var() would be absolutely wrong here, as then we'd
return garbage if such a path were actually possible.

Your original patch was fine and I'm going to apply it, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html