netdev - Re: [PATCH] net: Add DEVTYPE support for Ethernet based devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090904.214615.198838334.davem@davemloft.net>
Date:	Fri, 04 Sep 2009 21:46:15 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	marcel@...tmann.org
Cc:	netdev@...r.kernel.org, shemminger@...ux-foundation.org,
	johannes@...solutions.net
Subject: Re: [PATCH] net: Add DEVTYPE support for Ethernet based devices

From: Marcel Holtmann <marcel@...tmann.org>
Date: Sat, 05 Sep 2009 06:34:00 +0200

> What is ugly about it. Do you have any other recommendation on how let
> userspace know what type of Ethernet device it is?

Well, for one thing, you're wasting 48 bytes on 64-bit when all you're
really intrested in is one string.

Also, you didn't setup an assignment for plain ethernet devices,
you just handle the non-traditional devices that do ethernet
framing.  Is this intentional?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html