lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Sep 2009 18:49:29 +0200 From: Jarek Poplawski <jarkao2@...il.com> To: Patrick McHardy <kaber@...sh.net> Cc: netdev@...r.kernel.org Subject: Re: net_sched 05/07: reintroduce dev->qdisc for use by sch_api On Mon, Sep 07, 2009 at 03:16:29PM +0200, Patrick McHardy wrote: > Jarek Poplawski wrote: > >> @@ -1383,7 +1375,7 @@ static int tc_ctl_tclass(struct sk_buff *skb, struct nlmsghdr *n, void *arg) > >> pid = TC_H_MAKE(qid, pid); > >> } else { > >> if (qid == 0) > >> - qid = dev_queue->qdisc_sleeping->handle; > >> + qid = dev->qdisc->handle; > > > > Probably I miss something, but in mq root case it seems to never do > > anything we need. If so, it could be the example of possible issues > > elsewhere. > > Sorry, I'm not sure what you're saying .. > > > I thought this mq virtual root qdisc could be done more transparently > > and invisible for the current code, but it seems, in your > > implementation some pointers like this, or parent ids (especially > > TC_H_ROOT) might be different, and even if it works OK, needs a lot of > > verification. So, my question is, if it's really necessary. > > Same here. Nevermind! I simply had a dream there could be preserved some old meaning of "root" etc. within a queue but it doesn't make a sense with this kind of interface. Jarek P. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists