[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4AA93FB0.5060802@freescale.com>
Date: Thu, 10 Sep 2009 13:04:32 -0500
From: Scott Wood <scottwood@...escale.com>
To: avorontsov@...mvista.com
CC: David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
Andy Fleming <afleming@...escale.com>,
Timur Tabi <timur@...escale.com>, linuxppc-dev@...abs.org
Subject: Re: [PATCH v2 3/3] ucc_geth: Fix hangs after switching from full
to half duplex
Anton Vorontsov wrote:
> MPC8360 QE UCC ethernet controllers hang when changing link duplex
> under a load (a bit of NFS activity is enough).
>
> PHY: mdio@...02120:00 - Link is Up - 1000/Full
> sh-3.00# ethtool -s eth0 speed 100 duplex half autoneg off
> PHY: mdio@...02120:00 - Link is Down
> PHY: mdio@...02120:00 - Link is Up - 100/Half
> NETDEV WATCHDOG: eth0 (ucc_geth): transmit queue 0 timed out
> ------------[ cut here ]------------
> Badness at c01fcbd0 [verbose debug info unavailable]
> NIP: c01fcbd0 LR: c01fcbd0 CTR: c0194e44
> ...
>
> The cure is to disable the controller before changing speed/duplex
> and enable it afterwards.
>
> Since ugeth_graceful_stop_{tx,rx} now may be called from an atomic
> context, switch the two functions from msleep() to mdelay().
Ouch. Can we put this in a workqueue or something?
-Scott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists