netdev - Re: [PATCH -next] netxen: build fix for INET=n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AAAD345.4090902@qlogic.com>
Date:	Fri, 11 Sep 2009 15:46:29 -0700
From:	Dhananjay Phadke <dhananjay.phadke@...gic.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
CC:	netdev <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH -next] netxen: build fix for INET=n

grr .. I broke it again!

Thanks Randy for fixing.

Acked-by: Dhananjay Phadke <dhananjay@...xen.com>

Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> When CONFIG_INET is disabled, netxen has a build failure:
> 
> netxen_nic_main.c:(.text+0x118fd1): undefined reference to `netxen_config_indev_addr'
> 
> so make that function just an empty stub when CONFIG_INET=n.
> (not "inline" since that conflicts with other declarations of it)
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ---
>  drivers/net/netxen/netxen_nic_main.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> --- linux-next-20090911.orig/drivers/net/netxen/netxen_nic_main.c
> +++ linux-next-20090911/drivers/net/netxen/netxen_nic_main.c
> @@ -2450,6 +2450,10 @@ static struct notifier_block	netxen_netd
>  static struct notifier_block netxen_inetaddr_cb = {
>  	.notifier_call = netxen_inetaddr_event,
>  };
> +#else
> +static void
> +netxen_config_indev_addr(struct net_device *dev, unsigned long event)
> +{ }
>  #endif
>  
>  static struct pci_driver netxen_driver = {
> 
> 
> 
> 
> ---
> ~Randy
> LPC 2009, Sept. 23-25, Portland, Oregon
> http://linuxplumbersconf.org/2009/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html