netdev - Re: [PATCH RESEND] bonding: remap muticast addresses without using dev_close() and dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090911.123652.92869438.davem@davemloft.net>
Date:	Fri, 11 Sep 2009 12:36:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	monis@...taire.COM
Cc:	ogerlitz@...taire.com, fubar@...ibm.com,
	jgunthorpe@...idianresearch.com, netdev@...r.kernel.org,
	bonding-devel@...ts.sourceforge.net
Subject: Re: [PATCH RESEND] bonding: remap muticast addresses without using
 dev_close() and dev_open()

From: Moni Shoua <monis@...taire.COM>
Date: Thu, 10 Sep 2009 11:47:05 +0300

> I don't need to revert the entire patch. Only the dev_open() and
> dev_close() functions need to be removed and it is quite easy to
> review it in one patch.

I agree, this is the best way to submit this.

> I thought about it but the function arp_mc_map() which is called
> before and after the change in dev->type, relies on the value of
> dev->type. I could write the patch with one event after the type has
> changed and passing the old device type somehow (field prev_type in
> struct net_device?) but the resulted code will look clumsy (at least
> to me).

That's correct, dev->type must be setup correctly to both undo
and install things properly so this approach is correct.

But unfortunately this patch doesn't apply to net-next-2.6 and
you'll need to respin it against current sources so I can apply
it, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html