lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 11 Sep 2009 12:51:35 -0700 (PDT)
From:	David Miller <>
Subject: Re: [PATCH] atm: dereference of he_dev->rbps_virt in

From: David Miller <>
Date: Fri, 11 Sep 2009 12:37:25 -0700 (PDT)

> From: Roel Kluin <>
> Date: Sat, 05 Sep 2009 14:35:18 +0200
>> he_dev->rbps_virt or he_dev->rbpl_virt allocation may fail, so check
>> them. Make sure that he_init_group() cleans up after errors.
>> Signed-off-by: Roel Kluin <>
>> ---
>>> These new return statements will both leak resources allocated
>>> earlier.
>>> All the caller is going to do is return -ENOMEM as well and
>>> it does not cleanup actions at all.
>>> Please fix this up.
>> I am new to this api, so please review.
> Looks ok, applied, thanks.

Sorry I have to revert, you didn't even build test this.

Roel, I know you want me to take your changes serious, but I
absolutely cannot when you do stuff like this.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists