netdev - Re: [net-next PATCH] etherdevice.h: random_ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090911141554.0072d365@nehalam>
Date:	Fri, 11 Sep 2009 14:15:54 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Joe Perches <joe@...ches.com>
Cc:	David Miller <davem@...emloft.net>, jeffrey.t.kirsher@...el.com,
	netdev@...r.kernel.org, gospo@...hat.com, gregory.v.rose@...el.com,
	donald.c.skidmore@...el.com
Subject: Re: [net-next PATCH] etherdevice.h: random_ether_addr update

On Fri, 11 Sep 2009 13:20:42 -0700
Joe Perches <joe@...ches.com> wrote:

> On Fri, 2009-09-11 at 12:15 -0700, David Miller wrote:
> > From: Joe Perches <joe@...ches.com>
> > Date: Thu, 10 Sep 2009 20:02:43 -0700
> > > On Thu, 2009-09-10 at 19:07 -0700, Stephen Hemminger wrote:
> > >> On Thu, 10 Sep 2009 18:48:27 -0700
> > >> Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:
> > >> > From: Gregory Rose <gregory.v.rose@...el.com>
> > >> > This patch changes the default VF MAC address generation to use an Intel
> > >> > Organizational Unit Identifier (OUI), instead of a fully randomized
> > >> > Ethernet address.  This is to help prevent accidental MAC address
> > >> > collisions.
> > > I think this not a very good idea.
> > I also completely agree that this patch is not a wise move.
> 
> Perhaps this?
> 
> random_ether_address should not assign an "0x02" leading octet.
> 
> "02" has the local assignment bit set,
> but is actually a value assigned via OUI.
> 
> Do not use get_random_bytes to avoid drawing down entropy pool.
> 

Getting 6 bytes once is not going to be enough of a problem
to drain the pool. I prefer not to weaken the randomness here.


-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html