netdev - Re: [PATCH RFC] tun: export underlying socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15ddcffd0909140101waf04e91i918dd94143b1a7f4@mail.gmail.com>
Date:	Mon, 14 Sep 2009 11:01:54 +0300
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	Paul Moore <paul.moore@...com>, David Miller <davem@...emloft.net>,
	netdev@...r.kernel.org, herbert@...dor.apana.org.au,
	Or Gerlitz <ogerlitz@...taire.com>
Subject: Re: [PATCH RFC] tun: export underlying socket

On 9/11/09, Michael S. Tsirkin <mst@...hat.com> wrote:
>> On Fri, Sep 11, 2009 at 12:17:27AM -0400, Paul Moore wrote:
>>> No comments on the code at this point - I'm just trying to understand the
>>> intended user right now which I'm assuming is the vhost-net bits you sent previously

> More specifically, vhost would then be patched with:
>
>  diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
>  index aeffb3a..b54f9d6 100644
>  --- a/drivers/vhost/net.c
>  +++ b/drivers/vhost/net.c
>  @@ -331,15 +331,26 @@ err:
>         return ERR_PTR(r);
>   }
>
>  +static struct socket *get_tun_socket(int fd)
>  +{
>  +       struct file *file = fget(fd);
>  +       if (!file)
>  +               return ERR_PTR(-EBADF);
>  +       return tun_get_socket(file);
>  +}
>  +
>   static struct socket *get_socket(int fd)

Michael,

your latest posting "[PATCHv5 3/3] vhost_net: a kernel-level virtio
server" doesn't have a function named get_socket, so I don't see how
one can really get what you are up with this snip from vhost/net.c

Or.

>   {
>         struct socket *sock;
>         sock = get_raw_socket(fd);
>
>         if (!IS_ERR(sock))
>                 return sock;
>
> +       sock = get_tun_socket(fd);
>  +       if (!IS_ERR(sock))
>  +               return sock;
>         return ERR_PTR(-ENOTSOCK);
>   }
>
>   static long vhost_net_set_socket(struct vhost_net *n, int fd)
>   {
>         struct socket *sock, *oldsock = NULL;
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html