netdev - [PATCH] can: fix NOHZ local_softirq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AAF3AF2.60309@hartkopp.net>
Date:	Tue, 15 Sep 2009 08:57:54 +0200
From:	Oliver Hartkopp <oliver@...tkopp.net>
To:	David Miller <davem@...emloft.net>, stable@...nel.org
CC:	Linux Netdev List <netdev@...r.kernel.org>,
	Urs Thuermann <urs@...ogud.escape.de>,
	Michael Buesch <mb@...sch.de>
Subject: [PATCH] can: fix NOHZ local_softirq_pending 08 warning

When using nanosleep() in an userspace application we get a ratelimit warning

NOHZ: local_softirq_pending 08

for 10 times.

The echo of CAN frames is done from process context and softirq context only.
Therefore the usage of netif_rx() was wrong (for years).

This patch replaces netif_rx() with netif_rx_ni() which has to be used from
process/softirq context. It also adds a missing comment that can_send() must
no be used from hardirq context.

Signed-off-by: Oliver Hartkopp <oliver@...tkopp.net>
Signed-off-by: Urs Thuermann <urs@...ogud.escape.de>

---

View attachment "can-NOHZ-local_softirq_pending-08.patch" of type "text/x-patch" (1127 bytes)