netdev - Re: [PATCH 1/4] RxRPC: Declare the security index constants symbolically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20090915.024611.108935670.davem@davemloft.net>
Date:	Tue, 15 Sep 2009 02:46:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dhowells@...hat.com
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/4] RxRPC: Declare the security index constants
 symbolically


All 4 patches applied, but...

The rxrpc code seems to use a hodge-podge of uint32_t, uint16_t et
al. and the Linux kernel preferred "u8".

Please consolidate it all to use u32, u16, etc.

This looks especially weird since you use the endianness aware
fixed sized Linux types (be32, be16) as well.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html