netdev - Re: [PATCH 2/2] ems_usb: Added support for EMS CPC-USB/ARM7 CAN/USB interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AAF762A.5030605@gmail.com>
Date:	Tue, 15 Sep 2009 13:10:34 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Sebastian Haas <haas@...-wuensche.com>
CC:	netdev@...r.kernel.org, greg@...ah.com, wg@...ndegger.com,
	oliver@...tkopp.net, socketcan-core@...ts.berlios.de,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH 2/2] ems_usb: Added support for EMS CPC-USB/ARM7 CAN/USB
 interface

Sebastian Haas a écrit :
> This patch adds support for one channel CAN/USB interace CPC-USB/ARM7 from
> EMS Dr. Thomas Wuensche (http://www.ems-wuensche.com).
> 
> Signed-off-by: Sebastian Haas <haas@...-wuensche.com>
> ---
> 

...

> +	netif_rx(skb);
> +
> +	dev->netdev->last_rx = jiffies;

Please dont update last_rx unless your driver *really* needs to.

drivers/net/sky2.c is an example of driver that has to update ->last_rx
for its internal use.

But most drivers dont need it anymore, since core network
already update it if necessary  (check skb_bond_should_drop())


> +	stats->rx_packets++;
> +	stats->rx_bytes += cf->can_dlc;
> +}
> +
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html