lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 16 Sep 2009 02:10:51 -0700
From:	Daniel Walker <dwalker@...o99.com>
To:	jie.yang@...eros.com
Cc:	davem@...emloft.net, miles.lane@...il.com, chris.snook@...il.com,
	jcliburn@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [Patch net-next]atl1e:fix 2.6.31-git4 -- ATL1E 0000:03:00.0:
 DMA-API: device driver frees DMA

On Wed, 2009-09-16 at 14:21 +0800, jie.yang@...eros.com wrote:
> -           pci_unmap_page(pdev, tx_buffer->dma,
> +           if (tx_buffer->flags & ATL1E_TX_PCIMAP_SINGLE)
> +               pci_unmap_single(pdev, tx_buffer->dma,
> +                   tx_buffer->length, PCI_DMA_TODEVICE);
> +           else if (tx_buffer->flags & ATL1E_TX_PCIMAP_PAGE)
> +               pci_unmap_page(pdev, tx_buffer->dma,

Could you run this through checkpatch, and fix any errors if find? It
looks like you uses spaces for tabs in the code above, maybe in the
other block too..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists