netdev - [RFCv4 PATCH 0/2] net: Introduce recvmmsg socket syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20090916170733.GB7699@ghostprotocols.net>
Date:	Wed, 16 Sep 2009 14:07:33 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	Caitlin Bestler <caitlin.bestler@...il.com>,
	Chris Van Hoof <vanhoof@...hat.com>,
	Clark Williams <williams@...hat.com>,
	Neil Horman <nhorman@...driver.com>,
	Nir Tzachar <nir.tzachar@...il.com>,
	Nivedita Singhvi <niv@...ibm.com>,
	Paul Moore <paul.moore@...com>,
	Rémi Denis-Courmont 
	<remi.denis-courmont@...ia.com>,
	Steven Whitehouse <steve@...gwyn.com>,
	Linux Networking Development Mailing List 
	<netdev@...r.kernel.org>
Subject: [RFCv4 PATCH 0/2] net: Introduce recvmmsg socket syscall

Hi,

	Nir, can you please test with this patchset and check if latency
numbers improved? They should, I think :-)

	New perf callgraphs here:

http://oops.ghostprotocols.net:81/acme/perf.recvmsg.step2.cg.data.txt.bz2

versus

http://oops.ghostprotocols.net:81/acme/perf.recvmmsg.step2.cg.data.txt.bz2

	Look at what appears now on the radar, its not locking :-)
	
	Or course, I need to do more tests, but it looks promising, please give
it a go and report back here if you can!

- Arnaldo

# Samples: 761074
#
# Overhead   Command             Shared Object  Symbol
# ........  ........  ........................  ......
#
     6.54%  recvmmsg  [kernel]                  [k] skb_set_owner_r
                |
                |--99.43%-- sock_queue_rcv_skb
                |          __udp_queue_rcv_skb
                |          sk_backlog_rcv
                |          release_sock
                |          __sys_recvmmsg
                |          sys_recvmmsg
                |          system_call_fastpath
                |          syscall
                |          |
                |           --12.76%-- main
                |                     __libc_start_main
                |
                 --0.57%-- __udp_queue_rcv_skb
                           sk_backlog_rcv
                           release_sock
                           __sys_recvmmsg
                           sys_recvmmsg
                           system_call_fastpath
                           syscall
                           |
                            --10.84%-- main
                                      __libc_start_main

     5.88%  recvmmsg  [kernel]                  [k] _spin_lock_irqsave
                |
                |--47.58%-- skb_queue_tail
                |          sock_queue_rcv_skb
                |          __udp_queue_rcv_skb
                |          sk_backlog_rcv
                |          release_sock
                |          __sys_recvmmsg
                |          sys_recvmmsg
                |          system_call_fastpath
                |          syscall
                |          |
                |           --12.56%-- main
                |                     __libc_start_main
                |
                |--41.85%-- __skb_recv_datagram
                |          __udp_recvmsg
                |          udp_unlocked_recvmsg
                |          sock_common_unlocked_recvmsg
                |          __sock_unlocked_recvmsg_nosec
                |          |
                |          |--98.41%-- sock_unlocked_recvmsg_nosec
                |          |          __sys_recvmsg
                |          |          __sys_recvmmsg
                |          |          sys_recvmmsg
                |          |          system_call_fastpath
                |          |          syscall
                |          |          |
                |          |           --12.82%-- main
                |          |                     __libc_start_main
                |          |
                |           --1.59%-- sock_unlocked_recvmsg
                |                     __sys_recvmsg
                |                     __sys_recvmmsg
                |                     sys_recvmmsg


- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html