netdev - Re: [PATCH net-next-2.6] bonding: make ab_arp select active slaves as other modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090916.170520.233815224.davem@davemloft.net>
Date:	Wed, 16 Sep 2009 17:05:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fubar@...ibm.com
Cc:	jpirko@...hat.com, netdev@...r.kernel.org,
	bonding-devel@...ts.sourceforge.net, nicolas.2p.debian@...e.fr
Subject: Re: [PATCH net-next-2.6] bonding: make ab_arp select active slaves
 as other modes

From: Jay Vosburgh <fubar@...ibm.com>
Date: Wed, 16 Sep 2009 17:02:45 -0700

> Jiri Pirko <jpirko@...hat.com> wrote:
> 
>>When I was implementing primary_passive option (formely named primary_lazy) I've
>>run into troubles with ab_arp. This is the only mode which is not using
>>bond_select_active_slave() function to select active slave and instead it
>>selects it itself. This seems to be not the right behaviour and it would be
>>better to do it in bond_select_active_slave() for all cases. This patch makes
>>this happen. Please review.
>>
>>Signed-off-by: Jiri Pirko <jpirko@...hat.com>
> 
> 	I tried to break this, and couldn't.  Tested with regular
> ethernet interfaces, as well as VLANs, and it does the right thing.
> 
> 	-J
> 
> Signed-off-by: Jay Vosburgh <fubar@...ibm.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html