lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Sep 2009 12:06:17 -0700 From: "Choi, David" <David.Choi@...rel.Com> To: "David Miller" <davem@...emloft.net>, <greg@...ah.com> Cc: <netdev@...r.kernel.org>, "Li, Charles" <Charles.Li@...rel.Com>, <Choi@...ah.com>, <jgarzik@...hat.com>, <shemminger@...tta.com> Subject: RE: [PATCH] ks8851_ml ethernet network driver Hello David Miller, My fix ups are as followings; -Remove DEBUG definition -Remove MALLOC definition -Intent to fix compile warnings, which I can not reproduce in my test environment(linux-2.6.31-rc3 source tree and gcc4.2.1.) If you have still warnings with my fix ups, give me brief description To reproduce the warnings. ================= --- linux-2.6.31-rc3/drivers/net/ks8851_mll.c.orig 2009-09-17 10:18:56.000000000 -0700 +++ linux-2.6.31-rc3/drivers/net/ks8851_mll.c 2009-09-17 10:09:37.000000000 -0700 @@ -21,8 +21,6 @@ * KS8851 16bit MLL chip from Micrel Inc. */ -#define DEBUG - #include <linux/module.h> #include <linux/kernel.h> #include <linux/netdevice.h> @@ -419,7 +417,6 @@ union ks_tx_hdr { * or one of the work queues. * */ -#define MALLOC(x) kmalloc(x, GFP_KERNEL) /* Receive multiplex framer header info */ struct type_frame_head { @@ -552,11 +549,9 @@ static void ks_wrreg16(struct ks_net *ks */ static inline void ks_inblk(struct ks_net *ks, u16 *wptr, u32 len) { - u32 data_port = (u32)ks->hw_addr; len >>= 1; - do { - *wptr++ = (u16)ioread16(data_port); - } while (--len); + while (len--) + *wptr++ = (u16)ioread16(ks->hw_addr); } /** @@ -568,11 +563,9 @@ static inline void ks_inblk(struct ks_ne */ static inline void ks_outblk(struct ks_net *ks, u16 *wptr, u32 len) { - u32 data_port = (u32)ks->hw_addr; len >>= 1; - do { - iowrite16(*wptr++, data_port); - } while (--len); + while (len--) + iowrite16(*wptr++, ks->hw_addr); } /** Regards, David J. Choi -----Original Message----- From: David Miller [mailto:davem@...emloft.net] Sent: Wednesday, September 16, 2009 8:48 PM To: greg@...ah.com Cc: netdev@...r.kernel.org; Li, Charles; Choi@...ah.com; Choi, David; jgarzik@...hat.com; shemminger@...tta.com Subject: Re: [PATCH] ks8851_ml ethernet network driver From: Greg KH <greg@...ah.com> Date: Wed, 16 Sep 2009 19:38:36 -0700 > From: Choi, David <David.Choi@...rel.Com> > > This is a network driver for the ks8851 16bit MLL ethernet device. > > Signed-off-by: David J. Choi <david.choi@...rel.com> > Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de> This doesn't even build cleanly: drivers/net/ks8851_mll.c: In function 'ks_inblk': drivers/net/ks8851_mll.c:555: warning: cast from pointer to integer of different size drivers/net/ks8851_mll.c:558: warning: passing argument 1 of '_readw' makes pointer from integer without a cast drivers/net/ks8851_mll.c: In function 'ks_outblk': drivers/net/ks8851_mll.c:571: warning: cast from pointer to integer of different size drivers/net/ks8851_mll.c:574: warning: passing argument 2 of '_writew' makes pointer from integer without a cast It also has a big "#define DEBUG" at the beginning of the driver. And it also has stuff like: +#define MALLOC(x) kmalloc(x, GFP_KERNEL) which actually decreases the readability of this driver. Please fix this up. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists