[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <4AB67242.6060803@free.fr>
Date: Sun, 20 Sep 2009 20:19:46 +0200
From: Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>
To: netdev@...r.kernel.org
CC: David Miller <davem@...emloft.net>,
Jay Vosburgh <fubar@...ibm.com>,
bonding-devel@...ts.sourceforge.net
Subject: [PATCH net-next-2.6] bonding: remove useless assignment
The variable old_active is first set to bond->curr_active_slave.
Then, it is unconditionally set to new_active, without being used in between.
The first assignment, having no side effect, is useless.
Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>
---
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index a7e731f..fce7233 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1084,7 +1084,7 @@ static struct slave *bond_find_best_slave(struct bonding *bond)
int mintime = bond->params.updelay;
int i;
- new_active = old_active = bond->curr_active_slave;
+ new_active = bond->curr_active_slave;
if (!new_active) { /* there were no active slaves left */
if (bond->slave_cnt > 0) /* found one slave */
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists