netdev - Re: [PATCH 3/3] at91_can: add driver for Atmel's CAN controller on AT91SAM9263

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd73a99e0909211444x70af0b73k3db99d1ab379913f@mail.gmail.com>
Date:	Mon, 21 Sep 2009 23:44:24 +0200
From:	Andrew Victor <avictor.za@...il.com>
To:	Marc Kleine-Budde <mkl@...gutronix.de>
Cc:	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Socketcan-core@...ts.berlios.de,
	Andrew Victor <linux@...im.org.za>, wg@...ndegger.com
Subject: Re: [PATCH 3/3] at91_can: add driver for Atmel's CAN controller on 
	AT91SAM9263

hi Marc,

> +static inline u32 at91_read(const struct at91_priv *priv, enum at91_reg reg)
> +{
> +       return readl(priv->reg_base + reg);
> +}
> +
> +static inline void at91_write(const struct at91_priv *priv, enum at91_reg reg,
> +               u32 value)
> +{
> +       writel(value, priv->reg_base + reg);
> +}

Rather use __raw_readl() and __raw_writel().


Regards,
  Andrew Victor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html