netdev - Re: [PATCH 02/13] TProxy: add lookup type checks for UDP in nf_tproxy_get_sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1253601613.6883.7.camel@bzorp.balabit>
Date:	Tue, 22 Sep 2009 08:40:13 +0200
From:	Balazs Scheidler <bazsi@...abit.hu>
To:	Jan Engelhardt <jengelh@...ozas.de>
Cc:	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 02/13] TProxy: add lookup type checks for UDP in
 nf_tproxy_get_sock_v4()

On Mon, 2009-09-21 at 23:20 +0200, Jan Engelhardt wrote:
> On Saturday 2009-08-15 14:01, Balazs Scheidler wrote:
> 
> >+	case IPPROTO_UDP:
> >+		sk = udp4_lib_lookup(net, saddr, sport, daddr, dport,
> >+				     in->ifindex);
> 
> You might want to add IPPROTO_UDPLITE in all places.

Well, I preferred not to add those, as I'm unable to test it, and I'd
prefer to submit a patch that really works for UDP and TCP at the
minimum. Further protocols (like SCTP) should be added later IMHO.

-- 
Bazsi

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html