netdev - Re: [RFC][PATCH] pcmcia: pcnet_cs.c removing useless condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090922.141716.236597540.davem@davemloft.net>
Date:	Tue, 22 Sep 2009 14:17:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jaswinder@...nel.org
Cc:	jeff@...zik.org, netdev@...r.kernel.org,
	linux-pcmcia@...ts.infradead.org, linux@...inikbrodowski.net
Subject: Re: [RFC][PATCH] pcmcia: pcnet_cs.c removing useless condition

From: Jaswinder Singh Rajput <jaswinder@...nel.org>
Date: Sun, 13 Sep 2009 00:38:49 +0530

> [This is untested]
> 
> 'if (i < NR_INFO)' will only true if we breaks from 'for (i = 0; i < NR_INFO; i++)'
> So removing useless 'if (i < NR_INFO)'
> 
> This also fixed following compilation warning :
> 
>   CC [M]  drivers/net/pcmcia/pcnet_cs.o
> drivers/net/pcmcia/pcnet_cs.c: In function ‘get_hwinfo’:
> drivers/net/pcmcia/pcnet_cs.c:321: warning: ‘base’ may be used uninitialized in this function
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>

Looks good to me, applied.