netdev - Re: Getting physical packet counts with LRO enabled with ixgbe?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Sep 2009 14:56:09 -0700
From:	Ben Greear <greearb@...delatech.com>
To:	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
CC:	NetDev <netdev@...r.kernel.org>
Subject: Re: Getting physical packet counts with LRO enabled with ixgbe?

I'm poking at the ixgbe_main code in 2.6.31.

It seems from the spec sheet that the 82599 supports the GORCH.

	/* 82598 hardware only has a 32 bit counter in the high register */
	if (hw->mac.type == ixgbe_mac_82599EB) {
		adapter->stats.gorc += IXGBE_READ_REG(hw, IXGBE_GORCL);
		IXGBE_READ_REG(hw, IXGBE_GORCH); /* to clear */

stats.gorc is 64-bit, so any reason not to grab the 4 high-bits out of GORCL
and add them to stats.gorc instead of just clearing them as this
code seems to do?

That gives us some precious extra seconds to read counters before they
wrap :)

Thanks,
Ben

-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html