netdev - Re: [RFC] skb align patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090923054748.GA24045@bombadil.infradead.org>
Date:	Wed, 23 Sep 2009 01:47:48 -0400
From:	Thomas Graf <tgraf@...radead.org>
To:	David Miller <davem@...emloft.net>
Cc:	eric.dumazet@...il.com, shemminger@...tta.com,
	jesse.brandeburg@...il.com, hawk@...u.dk, netdev@...r.kernel.org
Subject: Re: [RFC] skb align patch

On Mon, Sep 21, 2009 at 10:29:40PM -0700, David Miller wrote:
> The alignment in this patch is a real big deal for 64 byte forwarding
> tests, where the entire packet is a whole PCI-E cacheline.  But not
> if it isn't aligned properly.

As I pointed out to Herbert already, this alignment change may actually
make things worse or even break things as long as compare_ether_header()
used in __napi_gro_receive() expects the IP header to be aligned to 4
bytes. That can be fixed of course, just wanted to mention it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html