netdev - Re: ixgbe patch to provide NIC's tx/rx counters via ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9929d2390909241210o6f0a640bi842307b5742c0699@mail.gmail.com>
Date:	Thu, 24 Sep 2009 12:10:45 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
Cc:	Ben Greear <greearb@...delatech.com>,
	NetDev <netdev@...r.kernel.org>
Subject: Re: ixgbe patch to provide NIC's tx/rx counters via ethtool

On Thu, Sep 24, 2009 at 11:28, Peter P Waskiewicz Jr
<peter.p.waskiewicz.jr@...el.com> wrote:
> On Wed, 2009-09-23 at 15:36 -0700, Ben Greear wrote:
>> When LRO is enabled, the received packet and byte counters represent the
>> LRO'd packets, not the packets/bytes on the wire.  The Intel 82599 NIC has
>> registers that keep count of the physical packets.  Add these counters to
>> the ethtool stats.  The byte counters are 36-bit, but the high 4 bits were
>> being ignored in the 2.6.31 ixgbe driver:  Read those as well to allow
>> longer time between polling the stats to detect wraps.
>>
>> Signed-off-by: Ben Greear <greearb@...delatech.com>
>>
>>
>> Please do not apply this until the ixgbe authors ACK it.  There may
>> have been reasons for not reading the high 4 bits, or they may dislike
>> this approach entirely.
>
> Aside from the trivial line-wrap on the comments, I'm fine with this
> patch.  There is no issue I could find with the hardware that would
> limit you from reading the high 4 bits.  And since we're reading it
> already to clear the register, we might as well use the value we get
> from it.
>
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
>

I have added this patch to my tree and will push along with my other
ixgbe patches to dave/netdev.  Thanks.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html