netdev - Re: [PATCH] tunnel: eliminate recursion field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090924.154710.248674101.davem@davemloft.net>
Date:	Thu, 24 Sep 2009 15:47:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] tunnel: eliminate recursion field

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 23 Sep 2009 22:28:33 +0200

> Eric Dumazet a écrit :
>> It seems recursion field from "struct ip_tunnel" is not anymore needed.
>> recursion prevention is done at the upper level (in dev_queue_xmit()),
>> since we use HARD_TX_LOCK protection for tunnels.
>> 
>> This avoids a cache line ping pong on "struct ip_tunnel" : This structure
>> should be now mostly read on xmit and receive paths.
> 
> Oops I forgot ipv6 tunnels, silly me, here is an updated version.
> 
> Thanks
> 
> [PATCH] tunnel: eliminate recursion field
> 
> It seems recursion field from "struct ip_tunnel" is not anymore needed.
> recursion prevention is done at the upper level (in dev_queue_xmit()),
> since we use HARD_TX_LOCK protection for tunnels.
> 
> This avoids a cache line ping pong on "struct ip_tunnel" : This structure
> should be now mostly read on xmit and receive paths.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html