netdev - Re: [PATCH] ax25: Fix ax25_cb refcounting in ax25_ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090925183504.GA3307@del.dom.local>
Date:	Fri, 25 Sep 2009 20:35:04 +0200
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Ralf Baechle DL5RB <ralf@...ux-mips.org>
Cc:	David Miller <davem@...emloft.net>,
	Bernard Pidoux F6BVP <f6bvp@...e.fr>,
	Bernard Pidoux <bernard.pidoux@...c.fr>,
	Linux Netdev List <netdev@...r.kernel.org>,
	linux-hams <linux-hams@...r.kernel.org>
Subject: Re: [PATCH] ax25: Fix ax25_cb refcounting in ax25_ctl_ioctl

On Fri, Sep 25, 2009 at 02:40:52PM +0100, Ralf Baechle DL5RB wrote:
> On Fri, Sep 25, 2009 at 01:10:38PM +0000, Jarek Poplawski wrote:
> 
> > This bug isn't responsible for these oopses here, but looks quite
> > obviously. (I'm not sure if it's easy to test/hit with the common
> > tools.)
> 
> The issue your patch fixes is obvious enough.

Yes, with new code there would be no doubt. But here, if you know it's
worked for some time, you wonder if you're not blind. |-)
> 
> > Jarek P.
> > ------------>
> > [PATCH] ax25: Fix ax25_cb refcounting in ax25_ctl_ioctl
> > 
> > Use ax25_cb_put after ax25_find_cb in ax25_ctl_ioctl.
> > 
> > Reported-by: Bernard Pidoux F6BVP <f6bvp@...e.fr>
> > Signed-off-by: Jarek Poplawski <jarkao2@...il.com>
> 
> Reviewed-by: Ralf Baechle <ralf@...ux-mips.org>
> 
Thanks for reviewing,
Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html