netdev - Re: [PATCH v2 2/2 scsi-post-merge] cxgb3i: support of private MAC address in iSCSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ABD61FA.2040609@cs.wisc.edu>
Date:	Fri, 25 Sep 2009 19:36:10 -0500
From:	Mike Christie <michaelc@...wisc.edu>
To:	kxie@...lsio.com
CC:	James.Bottomley@...senPartnership.com, davem@...emloft.net,
	swise@...ngridcomputing.com, divy@...lsio.com, rakesh@...lsio.com,
	linux-scsi@...r.kernel.org, open-iscsi@...glegroups.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2 2/2 scsi-post-merge] cxgb3i: support of private MAC
 address in iSCSI

kxie@...lsio.com wrote:
> [PATCH v2 2/2 scsi-post-merge] cxgb3i: private MAC address for iSCSI
> 
> From: Karen Xie <kxie@...lsio.com>
>         
> This patch updated the use of private MAC address per port in iscsi.
> 
> This patch is generated against scsi-post-merge.
>              
> Signed-off-by: Karen Xie <kxie@...lsio.com>
> --- 
>  drivers/scsi/cxgb3i/cxgb3i_offload.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/drivers/scsi/cxgb3i/cxgb3i_offload.h b/drivers/scsi/cxgb3i/cxgb3i_offload.h
> index 6a1d86b..f585ece 100644
> --- a/drivers/scsi/cxgb3i/cxgb3i_offload.h
> +++ b/drivers/scsi/cxgb3i/cxgb3i_offload.h
> @@ -234,9 +234,9 @@ struct sge_opaque_hdr {
>   * get and set private ip for iscsi traffic
>   */
>  #define cxgb3i_get_private_ipv4addr(ndev) \
> -	(((struct port_info *)(netdev_priv(ndev)))->iscsi_ipv4addr)
> +	(((struct port_info *)(netdev_priv(ndev)))->iscsic.ipv4_addr)
>  #define cxgb3i_set_private_ipv4addr(ndev, addr) \
> -	(((struct port_info *)(netdev_priv(ndev)))->iscsi_ipv4addr) = addr
> +	(((struct port_info *)(netdev_priv(ndev)))->iscsic.ipv4_addr) = addr
>  

This looks ok.

Reviewed-by Mike Christie <michaelc@...wisc.edu>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html