netdev - Re: [PATCH 2/7] mlx4: Query for loopback support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 01 Oct 2009 13:34:44 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yevgenyp@...lanox.co.il
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/7] mlx4: Query for loopback support

From: Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Date: Thu, 01 Oct 2009 16:33:27 +0200

> +	int			loopback_support;

You don't need a full 32-bit integer to store what
amounts to a single bit of boolean state.

Please store this in a flags word somewhere, or
if nothing appropriate exists, use a 'bool'.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html