netdev - Re: [PATCH] tg3: Remove prev_vlan_tag from struct tx_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091001.143859.53379358.davem@davemloft.net>
Date:	Thu, 01 Oct 2009 14:38:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mcarlson@...adcom.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org, mchan@...adcom.com
Subject: Re: [PATCH] tg3: Remove prev_vlan_tag from struct tx_ring_info

From: "Matt Carlson" <mcarlson@...adcom.com>
Date: Wed, 30 Sep 2009 10:26:43 -0700

> On Wed, Sep 30, 2009 at 07:07:52AM -0700, Eric Dumazet wrote:
>> prev_vlan_tag field is not used.
>> 
>> Patch saves 512*8 bytes per tx queue ring on 64bit arches.
>> 
>> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> Looks good to me.
> 
> Acked-by: Matthew Carlson <mcarlson@...adcom.com>

Applied, thanks.

Eric, I had to apply this by hand because:

>> @@ -2412,7 +2412,6 @@ struct ring_info {
>>  
>>  struct tx_ring_info {
>>  	struct sk_buff                  *skb;
>> -	u32                             prev_vlan_tag;
>>  };

Your email client changed tabs into spaces.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html