netdev - Re: [PATCH] Use sk_mark for routing lookup in more places

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091001.151823.263194343.davem@davemloft.net>
Date:	Thu, 01 Oct 2009 15:18:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	atis@...rotik.com, panther@...abit.hu, netdev@...r.kernel.org
Subject: Re: [PATCH] Use sk_mark for routing lookup in more places

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 01 Oct 2009 18:30:06 +0200

> Atis Elsts a écrit :
>> This patch against v2.6.31 adds support for route lookup using sk_mark in some 
>> more places. The benefits from this patch are the following.
>> First, SO_MARK option now has effect on UDP sockets too.
>> Second, ip_queue_xmit() and inet_sk_rebuild_header() could fail to do routing 
>> lookup correctly if TCP sockets with SO_MARK were used.
>> 
>> Signed-off-by: Atis Elsts <atis@...rotik.com>
> 
> Good catch, thanks !
> 
> I used SO_MARK on connected UDP sockets so did not notice the lack
> of functionality. (ip_route_connect() does use sk->sk_mark)
> 
> Acked-by: Eric Dumazet <eric.dumazet@...il.com>

Applied, thanks.

But Atis, your patch was whitespace corrupted by your email
client so I had to apply your patch by hand.  Please correct
this problem before submitting future patches, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html