netdev - Re: [PATCH] bcm63xx_enet: timeout off by one in do_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 30 Sep 2009 20:05:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mbizon@...ebox.fr
Cc:	roel.kluin@...il.com, netdev@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] bcm63xx_enet: timeout off by one in do_mdio_op()

From: Maxime Bizon <mbizon@...ebox.fr>
Date: Wed, 30 Sep 2009 16:01:28 +0200

> 
> On Mon, 2009-09-21 at 22:08 +0200, Roel Kluin wrote:
> 
> Hi Roel,
> 
>> `while (limit-- >= 0)' reaches -2 after the loop upon timeout.
> 
> The 1000us limit was chosen arbitrarily, since mdio access are much
> shorter, and was just to prevent CPU lockup in case of hardware bug.
> 
> But it looks like a bug, and since you're the second one reporting this,
> this should be fixed :)
> 
> 
>> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> 
> Acked-by: Maxime Bizon <mbizon@...ebox.fr>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html