netdev - Re: [PATCH 1/3] wireless: implement basic ethtool support for cfg80211 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1254387061.3959.20.camel@johannes.local>
Date:	Thu, 01 Oct 2009 10:51:01 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	"John W. Linville" <linville@...driver.com>
Cc:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	Kalle Valo <kalle.valo@...ia.com>,
	Kalle Valo <kalle.valo@....fi>,
	"Luis R. Rodriguez" <mcgrof@...il.com>
Subject: Re: [PATCH 1/3] wireless: implement basic ethtool support for
 cfg80211 devices

On Wed, 2009-09-30 at 21:19 -0400, John W. Linville wrote:

> +		if (!dev->ethtool_ops)
> +			dev->ethtool_ops = &cfg80211_ethtool_ops;
>  		break;

I might go so far and do it unconditionally so we get consistent
functionality across things. OTOH, full-mac drivers might be able to
support more.

> +const struct ethtool_ops cfg80211_ethtool_ops = {
> +	.get_drvinfo = cfg80211_get_drvinfo,
> +	.get_link = ethtool_op_get_link,
> +};
> +
> +void cfg80211_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)

if you change the order, you can make the latter static

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)