netdev - Re: [PATCH] af_packet: add interframe drop cmsg (v5)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091002002646.GA31016@localhost.localdomain>
Date:	Thu, 1 Oct 2009 20:26:46 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	David Miller <davem@...emloft.net>
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] af_packet: add interframe drop cmsg (v5)

On Thu, Oct 01, 2009 at 01:54:02PM -0700, David Miller wrote:
> From: Neil Horman <nhorman@...driver.com>
> Date: Wed, 30 Sep 2009 13:04:10 -0400
> 
> > @@ -207,7 +207,8 @@ struct packet_sock {
> >  };
> >  
> >  struct packet_skb_cb {
> > -	unsigned int origlen;
> > +	unsigned short origlen;
> > +	unsigned short gap;
> >  	union {
> >  		struct sockaddr_pkt pkt;
> >  		struct sockaddr_ll ll;
> 
> First of all, your commit message says the gap value is a u32
> whereas the code uses a u16.
> 
> Secondly, this is going to break with IPV6 jumbo grams which
> get us past the 64K barrier and thus whose lengths will exceed
> what fits in an unsigned short.
> 
ugh, so I really do need to do some sort of ring buffer implementation.  Ok,
I'll rework this tomorrow.

Neil

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html