netdev - Re: [PATCH] TCPCT-1: adding a sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877hvdbj55.fsf@basil.nowhere.org>
Date:	Fri, 02 Oct 2009 23:06:30 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	William Allen Simpson <william.allen.simpson@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] TCPCT-1: adding a sysctl

William Allen Simpson <william.allen.simpson@...il.com> writes:
>
> Any suggestions for improvement?  Or general approval?

The patch seems incomplete, can't find callers for most of the new functions.

In general cookies fell a bit out of favour because they don't support window
scaling etc.  But you don't seem to fix that by putting that data into
the new option.

My immediate gut reaction is that it will be likely challenging to 
traverse many packet filters (which often have a tendency to drop
anything they don't know) with this option on. That is also what killed
ECN.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html