netdev - Re: [PATCH] connector: Keep the skb in cn_callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091004145057.3de230a9.akpm@linux-foundation.org>
Date:	Sun, 4 Oct 2009 14:50:57 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Philipp Reisner <philipp.reisner@...bit.com>
Cc:	Evgeniy Polyakov <zbr@...emap.net>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, Lars Ellenberg <lars.ellenberg@...bit.com>
Subject: Re: [PATCH] connector: Keep the skb in cn_callback_data

On Tue, 29 Sep 2009 16:48:08 +0200 Philipp Reisner <philipp.reisner@...bit.com> wrote:

> Signed-off-by: Philipp Reisner <philipp.reisner@...bit.com>
> Acked-by: Lars Ellenberg <lars.ellenberg@...bit.com>

Please don't send unchangelogged patches.

> diff --git a/include/linux/connector.h b/include/linux/connector.h
> index 47ebf41..05a7a14 100644
> --- a/include/linux/connector.h
> +++ b/include/linux/connector.h
> @@ -134,8 +134,8 @@ struct cn_callback_id {
>  struct cn_callback_data {
>  	void (*destruct_data) (void *);
>  	void *ddata;
> -	
> -	void *callback_priv;
> +
> +	struct sk_buff *skb;
>  	void (*callback) (struct cn_msg *);
>  
>  	void *free;

This one replaces the void* private pointer with the skb but you didn't
explain to us why this was done.

Also, the patch does two things.  It _adds_ the skb pointer and it also
_removes_ the opaque void* private-data pointer for the callbacks. 
What are the implications of removing callback_priv?  Why was this done?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html