netdev - Re: [PATCH] inet_peer: Optimize inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 05 Oct 2009 00:08:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH] inet_peer: Optimize inet_getid()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 24 Sep 2009 22:44:53 +0200

> [PATCH] inet_peer: Optimize inet_getid()
> 
> While investigating for network latencies, I found inet_getid() was a contention point
> for some workloads.
> 
> If __HAVE_ARCH_CMPXCHG is defined, we can use cmpxchg() instead of
> a spin_lock_bh()/spin_unlock_bh() pair on a central lock.
> 
> On other arches, we can use an atomic_t instead of a u16,
> and atomic_add_return(). This might grow memory usage a bit, unless
> someone invents atomic16_t :)
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

I can't apply this, it's going to break the build on some
architectures.

For example, sparc64 only supports cmpxchg on u32 and u64
objects, but you're trying to use it on a u16 here.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html