netdev - Re: [PATCH 3/4] net: Convert ethtool {get_stats,self_test}_count() ops to get_sset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091005.001250.27034908.davem@davemloft.net>
Date:	Mon, 05 Oct 2009 00:12:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eilong@...adcom.com
Cc:	bhutchings@...arflare.com, chien.tin.tung@...el.com,
	faisal.latif@...el.com, subbus@...verengines.com,
	sathyap@...verengines.com, benh@...nel.crashing.org,
	jwboyer@...ux.vnet.ibm.com, alexander.h.duyck@...el.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 3/4] net: Convert ethtool {get_stats,self_test}_count()
 ops to get_sset_count()

From: "Eilon Greenstein" <eilong@...adcom.com>
Date: Sun, 4 Oct 2009 17:07:21 +0200

> On Thu, 2009-10-01 at 14:32 -0700, Ben Hutchings wrote:
>> These string query operations were supposed to be replaced by the
>> generic get_sset_count() starting in 2007.  Convert the remaining
>> implementations.
>> 
>> Also remove calls to these operations to initialise drvinfo->n_stats.
>> The ethtool core code already does that.
>> 
>> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
>> ---
>>  drivers/infiniband/hw/nes/nes_nic.c |   12 ++++---
>>  drivers/net/benet/be_ethtool.c      |   11 +++++--
>>  drivers/net/bnx2x_main.c            |   60 ++++++++++++++++++-----------------
>>  drivers/net/ibm_newemac/core.c      |   10 +++--
>>  drivers/net/igbvf/ethtool.c         |   25 +++++++-------
>>  drivers/net/niu.c                   |    7 +++-
>>  6 files changed, 70 insertions(+), 55 deletions(-)
>> 
> Thanks Ben, bnx2x tested and works just fine with this patch.
> Acked-by: Eilon Greenstein <eilong@...adcom.com>

Applied to net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html