netdev - Re: [Bonding-devel] [PATCH net-next-2.6] bonding: remove useless assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 07 Oct 2009 22:24:45 +0200
From:	Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>
To:	netdev@...r.kernel.org
CC:	Jay Vosburgh <fubar@...ibm.com>,
	David Miller <davem@...emloft.net>,
	bonding-devel@...ts.sourceforge.net
Subject: Re: [Bonding-devel] [PATCH net-next-2.6] bonding: remove useless
 assignment

Nicolas de Pesloüan wrote:
> The variable old_active is first set to bond->curr_active_slave.
> Then, it is unconditionally set to new_active, without being used in between.
> 
> The first assignment, having no side effect, is useless.
> 
> Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>
> Reviewed-by: Jiri Pirko <jpirko@...hat.com>
> 
> ---
> 
> Resent after fixing tab to space corruption.
> 
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index a7e731f..fce7233 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -1084,7 +1084,7 @@ static struct slave *bond_find_best_slave(struct bonding *bond)
> 	int mintime = bond->params.updelay;
> 	int i;
> 
> -	new_active = old_active = bond->curr_active_slave;
> +	new_active = bond->curr_active_slave;
> 
> 	if (!new_active) { /* there were no active slaves left */
> 		if (bond->slave_cnt > 0)   /* found one slave */

Apparently still some issues with patch formating. I will investigate this and post later.

	Nicolas.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html