netdev - Re: [net-next-2.6 PATCH V2] can: add TI CAN (HECC) driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091007.034917.68739080.davem@davemloft.net>
Date:	Wed, 07 Oct 2009 03:49:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	wg@...ndegger.com
Cc:	anantgole@...com, netdev@...r.kernel.org,
	socketcan-core@...ts.berlios.de,
	linux-arm-kernel@...ts.arm.linux.org.uk
Subject: Re: [net-next-2.6 PATCH V2] can: add TI CAN (HECC) driver

From: David Miller <davem@...emloft.net>
Date: Wed, 07 Oct 2009 03:44:25 -0700 (PDT)

> From: Wolfgang Grandegger <wg@...ndegger.com>
> Date: Wed, 07 Oct 2009 09:15:24 +0200
> 
>> Anant Gole wrote:
>>> TI HECC (High End CAN Controller) module is found on many TI devices. It
>>> has 32 hardware mailboxes with full implementation of CAN protocol 2.0B
>>> with bus speeds up to 1Mbps. Specifications of the module are available
>>> on TI web <http://www.ti.com>
>>> 
>>> Signed-off-by: Anant Gole <anantgole@...com>
>> 
>> Signed-off-by: Wolfgang Grandegger <wg@...ndegger.com>
>> 
>> Thanks for your contribution.
> 
> Applied, thanks everyone.

Actually I have to revert this.

You have to add restrictions to the Kconfig entry for this
driver so that it only builds where the necessary interfaces
exist.

Otherwise it will fail to link on non-ARM platforms because
they lack the clk_*() functions this driver uses.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html