netdev - Re: [PATCH 3/4] ethoc: align received packet to make IP header at word boundary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091007091337.532d9ed1@nehalam>
Date:	Wed, 7 Oct 2009 09:13:37 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Thomas Chou <thomas@...ron.com.tw>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 3/4] ethoc: align received packet to make IP header at
 word boundary

On Mon,  5 Oct 2009 17:33:19 +0800
Thomas Chou <thomas@...ron.com.tw> wrote:

> The packet buffer is allocated at 4 bytes boundary, but the IP header
> length and version bits is located at byte 14. These bit fields access
> as 32 bits word and caused exception on processors that do not support
> unaligned access.
> 
> The patch adds 2 bytes offset to make the bit fields word aligned.
> 
> Signed-off-by: Thomas Chou <thomas@...ron.com.tw>
> ---
>  drivers/net/ethoc.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/ethoc.c b/drivers/net/ethoc.c
> index f92747f..0c6c7f4 100644
> --- a/drivers/net/ethoc.c
> +++ b/drivers/net/ethoc.c
> @@ -399,6 +399,10 @@ static int ethoc_rx(struct net_device *dev, int limit)
>  		if (ethoc_update_rx_stats(priv, &bd) == 0) {
>  			int size = bd.stat >> 16;
>  			struct sk_buff *skb = netdev_alloc_skb(dev, size);
> +
> +			size -= 4; /* strip the CRC */
> +			skb_reserve(skb, 2); /* align TCP/IP header */

Please use NET_IP_ALIGN rather than hard coding 2 so that the value
can be changed on a per-cpu architecture basis if desired.

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html