netdev - RE: [PATCH] can: make the number of echo skb's configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2A3DCF3DA181AD40BDE86A3150B27B6B02F67E1776@dbde02.ent.ti.com>
Date:	Fri, 9 Oct 2009 14:31:09 +0530
From:	"Gole, Anant" <anantgole@...com>
To:	Wolfgang Grandegger <wg@...ndegger.com>,
	Linux Netdev List <netdev@...r.kernel.org>
CC:	SocketCAN Core Mailing List <socketcan-core@...ts.berlios.de>,
	Sebastian Haas <haas@...-wuensche.com>
Subject: RE: [PATCH] can: make the number of echo skb's configurable

>-----Original Message-----
>From: Wolfgang Grandegger [mailto:wg@...ndegger.com]
>Sent: Friday, October 09, 2009 1:47 PM
>To: Linux Netdev List
>Cc: SocketCAN Core Mailing List; Gole, Anant; Sebastian Haas
>Subject: [PATCH] can: make the number of echo skb's configurable
>
>This patch allows the CAN controller driver to define the number of echo
>skb's used for the local loopback (echo), as suggested by Kurt Van
>Dijck, with the function:
>
>  struct net_device *alloc_candev(int sizeof_priv,
>                                  unsigned int echo_skb_max);
>
>The CAN drivers have been adapted accordingly. For the ems_usb driver,
>as suggested by Sebastian Haas, the number of echo skb's has been
>increased to 10, which improves the transmission performance a lot.
>
>Signed-off-by: Wolfgang Grandegger <wg@...ndegger.com>
>Signed-off-by: Kurt Van Dijck <kurt.van.dijck@....be>
>---

[snip]

>Index: net-next-2.6/drivers/net/can/ti_hecc.c
>===================================================================
>--- net-next-2.6.orig/drivers/net/can/ti_hecc.c
>+++ net-next-2.6/drivers/net/can/ti_hecc.c
>@@ -74,10 +74,6 @@ MODULE_VERSION(HECC_MODULE_VERSION);
> #define HECC_MB_TX_SHIFT	2 /* as per table above */
> #define HECC_MAX_TX_MBOX	BIT(HECC_MB_TX_SHIFT)
>
>-#if (HECC_MAX_TX_MBOX > CAN_ECHO_SKB_MAX)
>-#error "HECC: MAX TX mailboxes should be equal or less than
>CAN_ECHO_SKB_MAX"
>-#endif
>-
> #define HECC_TX_PRIO_SHIFT	(HECC_MB_TX_SHIFT)
> #define HECC_TX_PRIO_MASK	(MAX_TX_PRIO << HECC_MB_TX_SHIFT)
> #define HECC_TX_MB_MASK		(HECC_MAX_TX_MBOX - 1)
>@@ -902,7 +898,7 @@ static int ti_hecc_probe(struct platform
> 		goto probe_exit_free_region;
> 	}
>
>-	ndev = alloc_candev(sizeof(struct ti_hecc_priv));
>+	ndev = alloc_candev(sizeof(struct ti_hecc_priv), HECC_MAX_TX_MBOX);
> 	if (!ndev) {
> 		dev_err(&pdev->dev, "alloc_candev failed\n");
> 		err = -ENOMEM;

Ack for ti_hecc driver change. Thanks for the patch.

Regards,
Anant
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html