[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20091013.000153.165586109.davem@davemloft.net>
Date: Tue, 13 Oct 2009 00:01:53 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: bhutchings@...arflare.com
Cc: netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH 1/3] mdio: Advertise pause (flow control) settings even
if autoneg is off
From: Ben Hutchings <bhutchings@...arflare.com>
Date: Mon, 12 Oct 2009 20:26:17 +0100
> Currently, if pause autoneg is off we do not set either pause
> advertising flag. If autonegotiation of speed and duplex settings is
> enabled, there is no way for the link partner to distinguish this from
> our refusing to use pause frames.
>
> We should instead set the advertising flags according to the forced
> mode so that the link partner can follow our lead. This is consistent
> with the behaviour of other drivers.
>
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
Applied to net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists