netdev - Re: [PATCH] sb1250-mac: duplicate setting of bit V_MAC_RX_PL_THRSH(4) in sbmac_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 Oct 2009 03:48:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	roel.kluin@...il.com
Cc:	netdev@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] sb1250-mac: duplicate setting of bit
 V_MAC_RX_PL_THRSH(4) in sbmac_channel_start()

From: Roel Kluin <roel.kluin@...il.com>
Date: Tue, 06 Oct 2009 22:07:15 +0200

> The bit V_MAC_RX_PL_THRSH(4) was already set a few lines higher.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> Please review. Maybe it should be replaced by something else?

Maybe, but or'ing it in twice is definitely pointless.

Applied to net-next-2.6, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html