netdev - Re: [PATCH] net: add support for STMicroelectronics Ethernet controllers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AD47425.7050003@st.com>
Date:	Tue, 13 Oct 2009 14:35:49 +0200
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: add support for STMicroelectronics Ethernet controllers.

Hi Eric,

Giuseppe CAVALLARO wrote:
> I'm going to post a new patch for the stmmac as soon as I fix all these
> points.

Hoping to have well followed all your advice, I'm attaching the
patch again.

As you will see, I've reviewed the tx clean process by removing the
wrong check that improperly impacted the poll logic.
I've noticed an improvement in terms of performances as well (*).
Taking as example the tg3 driver, I've reviewed and modified the
locking mechanism (fixing the issue on tso you had raised).

Please, let me know if you have other suggestions and/or advice.

Regards,
Peppe

P.S. (*)
I've just done some stress tests on our STB (mb618 - STi7111 SH4-300
@450MHz) and I cannot see any failures or strange issues at this time.

Below a few first numbers obtained by using n-u-t-t-c-p:

>> UDP/IPv4 recv (buf length 1328bytes)
  112.3646 MB /  10.00 sec =   94.2405 Mbps 4 %TX 13 %RX 0 / 88722
drop/pkt 0.0s

>> UDP/IPv4 send (buf length 1328bytes)
  113.6716 MB /  10.01 sec =   95.2608 Mbps 25 %TX 3 %RX 0 / 89754
drop/pkt 0.0s

>> TCP/IPv4 recv (buf length 64KiB)
  112.1827 MB /  10.02 sec =   93.9609 Mbps 2 %TX 19 %RX 0 retrans 1.36
msRTT

>> TCP/IPv4 send (buf length 64KiB)
  112.1243 MB /  10.03 sec =   93.8176 Mbps 12 %TX 5 %RX 0 retrans 1.69
msRTT

View attachment "0001-net-add-support-for-STMicroelectronics-Ethernet-con.patch" of type "text/x-patch" (160327 bytes)