netdev - Re: [PATCH] net: add support for STMicroelectronics Ethernet controllers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Oct 2009 08:58:27 +0200
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: add support for STMicroelectronics Ethernet controllers.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Eric Dumazet wrote:
> I reviewed your code and found no obvious issues
> 
> Could you please avoid defining this
> 
> #define STMMAC_IP_ALIGN NET_IP_ALIGN
> 
> (I see tg3.c uses a similar TG3_RAW_IP_ALIGN, this is probably why you felt it was necessary :
> In case of tg3, TG3_RAW_IP_ALIGN is used in cases where we always want to align the
> IP/network header on dword boundaries, even on platforms where NET_IP_ALIGN)
> 
> I am not sure this is what you want for STM.
> 
> In that case, please check new netdev_alloc_skb_ip_align() helper

Hi Eric,

Yep, I like that. I've both removed the STMMAC_IP_ALIGN and used the
netdev_alloc_skb_ip_align in the new patch attached.

Regards,
Peppe
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrVdowACgkQ2Xo3j31MSSKOmACdEq1a658wn/zIeAGnbpznoLLl
PioAn1Q4tfkWg/1/9n/uotLw8zSXdgy9
=+NKn
-----END PGP SIGNATURE-----

View attachment "0001-net-add-support-for-STMicroelectronics-Ethernet-con.patch" of type "text/x-patch" (160177 bytes)