netdev - [net-next-2.6 PATCH 3/4 resent] TCPCT part 1c: redefine TCP header functions *_len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 15 Oct 2009 11:07:39 -0400
From:	William Allen Simpson <william.allen.simpson@...il.com>
To:	Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: [net-next-2.6 PATCH 3/4 resent] TCPCT part 1c: redefine TCP header
 functions *_len_th(), cleanup

Redefine two TCP header functions to accept TCP header pointer.
When subtracting, return signed int to allow error checking.

In the only two existing files using the latter function, clean up
confusing and inconsistent mixing of both byte and word offsets.
However, remove proposed header length checking, and document the
assumptions instead.  In the immortal words of the reviewer:

    This is transmit, and the packets can only come from the Linux
    TCP stack, not some external entity.

    You're being way too anal here, and adding these checks to
    drivers would be just a lot of rediculious bloat. [sic]

These functions will also be used in subsequent patches that implement
additional features.
---
   drivers/net/bnx2.c  |   22 +++++++++++++---------
   drivers/net/tg3.c   |   32 +++++++++++++++++---------------
   include/linux/tcp.h |   10 ++++++++--
   3 files changed, 38 insertions(+), 26 deletions(-)

View attachment "TCPCT+1-3.patch" of type "text/plain" (4446 bytes)