netdev - Re: [PATCH 1/2] Add an alternative cs89x0 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091016093659.GB330@e-circ.dyndns.org>
Date:	Fri, 16 Oct 2009 11:37:01 +0200
From:	Kurt Van Dijck <kurt.van.dijck@....be>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	netdev@...r.kernel.org, Lennert Buytenhek <kernel@...tstofly.org>,
	Ivo Clarysse <ivo.clarysse@...il.com>,
	Gilles Chanteperdrix <gilles.chanteperdrix@...omai.org>
Subject: Re: [PATCH 1/2] Add an alternative cs89x0 driver

On Wed, Apr 22, 2009 at 09:59:31AM +0200, Sascha Hauer wrote:
> The in Kernel driver is far beyond its age. it still does not use
> driver model and its mere presence in the Kernel image prevents
> booting my board. The CS8900 still is in use on some embedded
> boards, so this patch adds an alternative driver to the tree
> designed to replace the old one.
> 
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> ---
>  drivers/net/Kconfig         |   12 +
>  drivers/net/Makefile        |    1 +
>  drivers/net/cirrus-cs89x0.c |  847 +++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 860 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/net/cirrus-cs89x0.c
[...]
> diff --git a/drivers/net/cirrus-cs89x0.c b/drivers/net/cirrus-cs89x0.c
[...]
> +static void
> +cirrus_set_receive_mode(struct net_device *ndev)
> +{
> +	struct cirrus_priv *priv = netdev_priv(ndev);
> +
> +	spin_lock(&priv->lock);
> +

I found this function causing locking problems.
using spin_lock_irqsave/spin_lock_irqrestore solved them.

Can xxx_set_receive_mode be called with interrupts enabled?
I just want to make sure that I didn't break something elsewhere, and
I don't know ethernet (devices) that well.

Kurt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html